fix: [Validation] if_exist does not work with array data
#8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
force-pushed
the
fix-if_exist-with-array
branch
from
76118c6
to
83c15b2
Compare
michalsn
reviewed
Jun 12, 2024
system/Validation/FormatRules.php
Outdated
Comment on lines
32
to
35
| if (is_array($str)) { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why is this check only added here? Shouldn't it also be in other rules?
There was a problem hiding this comment.
Because there was an error when running phpunit.
But changing alpha is not good.
The Traditional Rules should not be changed as much as possible.
So I reverted it and changed the test code.
Traditional Rules exist only for backward compatibility. Do not use them in new projects. Even if you are already using them, we recommend switching to Strict Rules.
https://codeigniter4.github.io/CodeIgniter4/libraries/validation.html#traditional-rules
kenjis
force-pushed
the
fix-if_exist-with-array
branch
from
83c15b2
to
1ca24da
Compare
michalsn
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8956
Fixed the bug that If an array is passed, Validation with
if_existrule always returnstrue.Checklist: