Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError in DefinedRouteCollector::collect() #8957

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: TypeError in DefinedRouteCollector::collect() #8957

merged 2 commits into from
Jun 17, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 12, 2024 •
edited
Loading

Description
Fixes #8954

1) CodeIgniter\Router\DefinedRouteCollectorTest::testCollect
TypeError: CodeIgniter\Router\RouteCollection::getRoutesOptions(): Argument #1 ($from) must be of type ?string, int given, called in .../CodeIgniter4/system/Router/DefinedRouteCollector.php on line 48

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 12, 2024
@kenjis kenjis mentioned this pull request Jun 12, 2024
Closed
@kenjis kenjis merged commit 7aced76 into codeigniter4:develop Jun 17, 2024
41 checks passed
@kenjis kenjis deleted the fix-RouteCollection-TypeError branch June 17, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
3 participants
@kenjis @michalsn @paulbalandan