Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix helpers/form_helper.rst #8935

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

obozdag
Copy link
Contributor

@obozdag obozdag commented Jun 5, 2024

Description
Superseds #8915

  • Change HTML 'tag's to 'element's in helpers/form_helper.rst

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Change HTML 'tag's to 'element's in helpers/form_helper.rst
@kenjis kenjis added the documentation Pull requests for documentation only label Jun 5, 2024
…Kenjis) helpers/form_helper.rst

Fix some typos and expand csrf auto-generation explanation (by Kenjis) helpers/form_helper.rst
…y.rst

Add label to Enable CSRF Protection header in libraries/security.rst
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the link.

@kenjis kenjis changed the title docs: Change HTML 'tag's to 'element's in helpers/form_helper.rst docs: fix helpers/form_helper.rst Jun 5, 2024
@obozdag
Copy link
Contributor Author

obozdag commented Jun 5, 2024

@kenjis Sorry. Same mistake while copy paste.

@kenjis
Copy link
Member

kenjis commented Jun 5, 2024

My Suggested change was not to fix HTML link. Just fix the sample code format.

Added label to $globals in incoming/filters.rst
Fix filters-globals link in helpers/form_helper.rst
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 0ce62d9 into codeigniter4:develop Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants