Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Small typos in libraries/pagination.rst #8863

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

obozdag
Copy link
Contributor

@obozdag obozdag commented May 7, 2024

Description
Small typos in libraries/pagination.rst

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Small typos in libraries/pagination.rst
@kenjis kenjis added the documentation Pull requests for documentation only label May 8, 2024
@@ -291,7 +291,7 @@ page is page 3. If the surrounding count is 2, then the following links would sh
``hasPreviousPage()`` would return ``true`` since there is page 2. And,
``hasNextPage()`` would return ``true`` since there is page 4.

.. note:: The difference to `hasPrevious() & hasNext()`_ is that they are based
.. note:: The difference to `hasPreviousPage() & hasNextPage()`_ is that they are based
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the original text is something wrong, but is this really correct?
This is in the section of hasPreviousPage() & hasNextPage().

@kenjis kenjis added the waiting for info Issues or pull requests that need further clarification from the author label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only waiting for info Issues or pull requests that need further clarification from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants