Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameID value not set #110

Open
viet-nguyen-1926 opened this issue Feb 23, 2023 · 5 comments
Open

NameID value not set #110

viet-nguyen-1926 opened this issue Feb 23, 2023 · 5 comments

Comments

@viet-nguyen-1926
Copy link

viet-nguyen-1926 commented Feb 23, 2023

I have 2 questions
why login always need email and how can i disable it ?

Thank you in advance.

image

It has already in metadata file.

image

@upwebdesign
Copy link
Contributor

@viet-nguyen-1926, generally, email is used as an acceptable form of authentication across many platforms. At this time, there is no way to disable it or change it, for that matter. It does not appear that the NameId is required for SAML 2.0.

At the very least, an update can allow a config enable_nameid to default to true. If the value is false, we remove it from the metadata file and the assertion. However, I'd like to know if there are any unintended consequences.

Thoughts?

@viet-nguyen-1926
Copy link
Author

@viet-nguyen-1926, generally, email is used as an acceptable form of authentication across many platforms. At this time, there is no way to disable it or change it, for that matter. It does not appear that the NameId is required for SAML 2.0.

At the very least, an update can allow a config enable_nameid to default to true. If the value is false, we remove it from the metadata file and the assertion. However, I'd like to know if there are any unintended consequences.

Thoughts?

@upwebdesign
We will be happy to support as you say
I've tried deleting it in the library and I've tested it, but I don't see any serious errors
and it seems that it needs to be adjusted in the litesaml file to be completely resolved

@upwebdesign
Copy link
Contributor

@viet-nguyen-1926 I created a pull request #111 that addresses this concern. Please look and let me know if this will work. This code has yet to be tested to ensure the original functionality exists. Some help from the community would be nice as well. :)

@viet-nguyen-1926
Copy link
Author

viet-nguyen-1926 commented Mar 1, 2023

@upwebdesign
Thank you for your supporting.I have tested.
My SP: nextcloud and laravel app
Case 1: use_name_id: true -> it works normally
Case 2:'use_name_id' => false,
'name_id_format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified',
image
-> I got errors when i accessing to nexctcloud
invalid_response
A valid SubjectConfirmation was not found on this Response

@upwebdesign
Copy link
Contributor

@viet-nguyen-1926, thank you for testing this out. I will review it and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants