Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 fails if a broken symlink is present in the repo #1433

Open
cmaglie opened this issue May 16, 2024 · 1 comment
Open

v4 fails if a broken symlink is present in the repo #1433

cmaglie opened this issue May 16, 2024 · 1 comment
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@cmaglie
Copy link

cmaglie commented May 16, 2024

I'm trying to update the github action from v3 to v4, but the CI fails with this error:

Traceback (most recent call last):
  File "codecov_cli/main.py", line 83, in <module>
  File "codecov_cli/main.py", line 79, in run
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1688, in invoke
  File "click/core.py", line 1434, in invoke
  File "click/core.py", line 783, in invoke
  File "click/decorators.py", line 33, in new_func
  File "codecov_cli/commands/upload.py", line 257, in do_upload
  File "codecov_cli/services/upload/__init__.py", line 78, in do_upload_logic
  File "codecov_cli/services/upload/upload_collector.py", line 174, in generate_upload_data
  File "codecov_cli/services/upload/upload_collector.py", line 100, in _produce_file_fixes
  File "codecov_cli/services/upload/upload_collector.py", line [114](https://github.com/arduino/arduino-cli/actions/runs/9112950400/job/25053833785?pr=2522#step:8:115), in _get_file_fixes
FileNotFoundError: [Errno 2] No such file or directory: 'internal/integrationtest/compile_4/testdata/ValidSketchWithNonInoBrokenSketchFileSymlink/other_file.c'

(you can see it here until it lasts: https://github.com/arduino/arduino-cli/actions/runs/9112950400/job/25053833785?pr=2522#step:8:112)

the "missing" file is a broken symlink that we use in our integration tests suite:

$ ls -l internal/integrationtest/compile_4/testdata/ValidSketchWithNonInoBrokenSketchFileSymlink/
total 4
lrwxrwxrwx 1 cmaglie cmaglie  6 feb 28 15:58 other_file.c -> broken
-rw-rw-r-- 1 cmaglie cmaglie 31 feb 28 15:58 ValidSketchWithNonInoBrokenSketchFileSymlink.ino

The best fix in our use case is to catch the "No such file or directory" exception and ignore it.

@thomasrockhu-codecov thomasrockhu-codecov added the bug Something isn't working label May 28, 2024
@cmaglie
Copy link
Author

cmaglie commented Jun 24, 2024

Is there a plan to fix this issue? May I help with a PR?

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Aug 1, 2024
@thomasrockhu-codecov thomasrockhu-codecov added Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months Area: Report Upload Issues with pre-ingest report uploading labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading bug Something isn't working Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

2 participants