Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can an issue's Location refer to a directory? #58

Open
jwsloan opened this issue Nov 9, 2017 · 3 comments
Open

Can an issue's Location refer to a directory? #58

jwsloan opened this issue Nov 9, 2017 · 3 comments

Comments

@jwsloan
Copy link

jwsloan commented Nov 9, 2017

I've started on an Engine for todogroup/repolinter. Repolinter checks for the existence of specific files, content within files, and performs a few other helpful checks against a repo. It should work quite nicely with CodeClimate.

One issue I've run into is the requirement to provide a file path. If a file is missing, I would not have that to provide. It wouldn't make sense to provide a path to a file that does not exist. Instead, it seems reasonable to pass the root directory as the path. Can that be done within the spec?

@wfleming
Copy link
Contributor

Apologies for the very late reply here, this got missed & I'm just now going through some old issues among our repositories.

This use case is not currently supported within the spec or by our code. File paths must point at readable normal files checked into the repository.

We have discussed loosening this requirement at times, and allowing references to non-file entities (e.g. #45), but have no immediate plans to make any changes.

@wfleming
Copy link
Contributor

To your specific use case of wanting to report an issue on a file that doesn't exist: we've seen that come up before, and I believe the fix (hacky though it is) was to instead report the issue on some other related file that did exist.

@mateuszgorniak
Copy link

That something that would be very interesting for me too. I'd like to create an engine checking the code based on some of the best practices and as an example add an issue informing about missing Readme file. I know that you were asked about it for example here #18 so it seems to be a quite "hot" feature. Is it possible to add this feature to the specification and the engine? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants