Bugfix/2897 fix exponential backoff #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikpetzold
commented
Nov 17, 2023
| @@ -41,7 +41,8 @@ public class InfoUpdateTrigger extends AbstractEventHandler<InstanceEvent> { | |||
| public InfoUpdateTrigger(InfoUpdater infoUpdater, Publisher<InstanceEvent> publisher) { | |||
| super(publisher, InstanceEvent.class); | |||
| this.infoUpdater = infoUpdater; | |||
| this.intervalCheck = new IntervalCheck("info", this::updateInfo, Duration.ofMinutes(5), Duration.ofMinutes(1)); | |||
| this.intervalCheck = new IntervalCheck("info", this::updateInfo, Duration.ofMinutes(5), Duration.ofMinutes(1), | |||
| Duration.ofMinutes(10)); | |||
There was a problem hiding this comment.
I don't like that we have defaults here (because we already have them in the AdminServerProperties).
In the AdminServerAutoConfiguration we call the setters to override these values anyways.
Can't we just pass the values to this constructor here? Then we could get rid of these defaults here and also get rid of the setters which are just passing the value to the next object.
There was a problem hiding this comment.
hm, the setters are also used in tests, makes them easier
There was a problem hiding this comment.
changed this, but kept the setters for tests
|
closes #2897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.