Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members can leave a testimonial #1438

Open
3 of 15 tasks
despo opened this issue Nov 17, 2020 · 9 comments
Open
3 of 15 tasks

Members can leave a testimonial #1438

despo opened this issue Nov 17, 2020 · 9 comments
Assignees

Comments

@despo
Copy link
Member

despo commented Nov 17, 2020

Description of the issue 📄

A member that has attended more than X events and has no testimonial associated with them can leave a testimonial

  • Add controller and related view so that a new member can add a testimonial
    • Add some text to inform members that any testimonial along with their name and profile picture might be used for the promotion of codebar (website, prospectus, etc)
    • Only allow for one testimonial per member
    • Once testimonial is created the page should no longer be available to member (or maybe a read-only version only can be available)
  • Extend testimonial model to have public boolean field
  • Add rake task to update existing testimonials to public
  • Add admin/testimonials#index page
    • List all testimonials, with member name, text, current status and actions columns
    • Enable admins to toggle the status
    • Only available to users with the admin role
  • Update main page testimonials query to only retrieve public testimonials - https://github.com/codebar/planner/blob/master/app/controllers/dashboard_controller.rb#L17

To do 📋

  • Claim this issue (comment below, or assign yourself if you are part of the codebar org)
  • Fork and clone the repository
  • Update the relevant files. Follow the steps to fix section in this issue.
  • Commit your changes as one commit. Use the title of this issue as your commit message
  • Submit a pull request
  • Mention this issue in the PR description by including it's number
  • Have your pull request reviewed & merged by a codebar team member
@claracavalcante
Copy link

I would like to claim this.

@matyikriszta
Copy link
Contributor

@claracavalcante sounds good, please go ahead with this issue

@github-actions
Copy link

github-actions bot commented Apr 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 5, 2021
@github-actions
Copy link

github-actions bot commented May 5, 2021

Closing as stale.

@matyikriszta
Copy link
Contributor

@despo I've been working on this issue and there are 3 questions that need clarifications:

  1. How many events should a member have attended to get the prompt to fill out a testimonial? I was thinking maybe 10 but happy to go with a different amount.

  2. How should the review process for testimonials look like? I'm thinking instead of a boolean public field we need an enum with at least 3 states: published, unpublished (or hidden/rejected) and in review. This way admins can be notified when a testimonial needs review and set it to either published or hidden (or rejected? Not sure what the terminology here should be). Similarly to how jobs work.

  3. Should a member be able to edit a testimonial? E.g. if there's a typo etc.

CC @KimberleyCook would love to hear your thoughts as well.

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jan 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Closing as stale.

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jan 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants