Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #5

Open
jesserosato opened this issue Jul 31, 2014 · 7 comments
Open

Testing #5

jesserosato opened this issue Jul 31, 2014 · 7 comments

Comments

@jesserosato
Copy link
Contributor

It would be really cool to get some testing working in WICIT. Check out the Angular.js tutorial for a nice intro to unit testing with Karma and end-to-end testing with Protractor.

@mikyladewitt
Copy link
Contributor

Do you still want help with this? I code in Angular so I have experience writing Jasmine Unit Tests and running the tests with Karma.

I looked at your Gruntfile and noticed you don't have any Karma grunt plugins set up or a karma.conf.js file. I can set that up for you too if you want.

@jesserosato
Copy link
Contributor Author

Hi Michi,

Thanks so much for your interest in WICit! If you want to set up testing frameworks that would be amazing!

  • Jesse


Sent from Mailbox

On Tue, Jun 2, 2015 at 8:48 PM, Michi [email protected] wrote:

Do you still want help with this? I code in Angular so I have experience writing Jasmine Unit Tests and running the tests with Karma.

I looked at your Gruntfile and noticed you don't have any Karma grunt plugins set up or a karma.conf.js file. I can set that up for you too if you want.

Reply to this email directly or view it on GitHub:
#5 (comment)

@mikyladewitt
Copy link
Contributor

Will do! Can I add all the framework to the existing Gruntfile so it all runs whenever you build it?

@jesserosato
Copy link
Contributor Author

That would be perfect! I use a setup like that at work myself and I love it.


Sent from Mailbox

On Tue, Jun 2, 2015 at 9:22 PM, Michi [email protected] wrote:

Will do! Can I add all the framework to the existing Gruntfile so it all runs whenever you build it?

Reply to this email directly or view it on GitHub:
#5 (comment)

@mikyladewitt
Copy link
Contributor

Sorry, life/work got a bit more hectic than I anticipated. I have karma up and running and I think about half of the angular files are tested. I'm going to try to jump back on this in the next couple days and finish it up then i can check it in.

@jesserosato
Copy link
Contributor Author

Hi Michi,

No worries! I know how that goes! It sounds like you’ve done a bunch already! If you get a chance to finish writing the tests, that’s awesome! Otherwise, feel free to push up the framework setup and the tests you have completed, so someone else can pick up the baton.

Thank you for your contributions to and interest in WICit!


Sent from Mailbox

On Tue, Jul 14, 2015 at 3:11 PM, Michi [email protected] wrote:

Sorry, life/work got a bit more hectic than I anticipated. I have karma up and running and I think about half of the angular files are tested. I'm going to try to jump back on this in the next couple days and finish it up then i can check it in.

Reply to this email directly or view it on GitHub:
#5 (comment)

@civicissuebot
Copy link

Hello! This issue looks like it still needs help!
It's been clicked on 61 times through the Civic Issue Finder on http://www.codeforamerica.org/.
Can this issue be closed or does it still need some assistance?

If you wrote this issue, you can always update the labels for specifying tasks, add more info in the description to make it easier to contribute, or re-write the title to make more contributors interested in helping out.
If you are an open source contributor, ask and see how you can help by commenting or check out more open issues in this repo at https://github.com/code4sac/wicit/issues.

Just doing a little 🌱 open source gardening 🌱 of Brigade projects!
For more info/tools for creating civic issues, check out Got Issues Thank you!

mikyladewitt added a commit to mikyladewitt/wicit that referenced this issue Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants