Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project code styling #44

Open
natebass opened this issue Nov 3, 2023 · 1 comment
Open

Project code styling #44

natebass opened this issue Nov 3, 2023 · 1 comment

Comments

@natebass
Copy link
Member

natebass commented Nov 3, 2023

I tried to follow the existing code as a guideline and reformatted all the project code in pull request #43. This is in preparation for the new design, so that new code has a consistent style to follow.

Styling your code this way is optional. Since there is no configuration file like eslintrc in the project root directory, the developer won't get any additional warnings in their editor.

Here is what it end up being.

  • 4 space width tabs.
  • Always use semi-colons at the end of Javascript statements.
  • Single quotes over double quotes.
  • Spaces around Javascript objects and import {}. For example, import { thing } from "thing".

Please let me know if there are any changes anyone would like to make.

@jeremiak
Copy link
Collaborator

jeremiak commented Nov 4, 2023

I'm fine with whatever style but I do think we should add a .prettierrc or something like that so and people can code in whatever style they want and have a bot clean it up for them. That way it doesn't really matter what people's preferences are, the codebase can be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants