Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reference the schema 'test' in SQL #59

Closed
kelfink opened this issue Aug 8, 2019 · 3 comments
Closed

Do not reference the schema 'test' in SQL #59

kelfink opened this issue Aug 8, 2019 · 3 comments
Assignees
@josephmfaulkner

Comments

@kelfink
Copy link
Collaborator

kelfink commented Aug 8, 2019

Aside from connection configuration, we should not be referencing the schema name 'test' in any code. The app probably only ever needs one schema, so it should be implicit. This will allow better configuration later in case someone wants to use a 'prod' schema or other.
@josephmfaulkner josephmfaulkner self-assigned this Aug 8, 2019
@josephmfaulkner
Copy link
Contributor

I'll get right on this one. While I'm at it I'll populate the public schema with the migrations.

@josephmfaulkner
Copy link
Contributor

@kelfink: I've got a PR open for this one.

@josephmfaulkner josephmfaulkner pinned this issue Aug 9, 2019
josephmfaulkner added a commit that referenced this issue Aug 9, 2019
@josephmfaulkner
Merge pull request #60 from code4sac/local-database
1b6432f 
Local Database and Fix Issue #59
@josephmfaulkner
Copy link
Contributor

Just merged this to DEV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephmfaulkner josephmfaulkner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelfink @josephmfaulkner