Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test binaries are always stripped due to behavior of rules_go #130586

Open
rickystewart opened this issue Sep 12, 2024 · 1 comment
Open
Labels
A-build-system branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Sep 12, 2024

It is impossible with rules_go to build an unstripped test binary. This is behavior that was adopted in bazelbuild/rules_go@9bbe81f. There is no command-line flag or similar that you can apply to disable this behavior. This should either be fixed upstream, or if it cannot, we should apply a patch to our fork that exposes the option.

internal discussion
See upstream issue

Jira issue: CRDB-42132

@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf labels Sep 12, 2024
Copy link

blathers-crl bot commented Sep 12, 2024

Hi @rickystewart, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@jlinder jlinder added the branch-master Failures and bugs on the master branch. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Development

No branches or pull requests

2 participants