Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: Doesn't show "network" docs when on "network/firewall" page #21040

Open
mvollmer opened this issue Sep 25, 2024 · 2 comments · May be fixed by #21072
Open

shell: Doesn't show "network" docs when on "network/firewall" page #21040

mvollmer opened this issue Sep 25, 2024 · 2 comments · May be fixed by #21072

Comments

@mvollmer
Copy link
Member

When on the "network/firewall" page, the "Help" menu does not include the networking docs:

image

@mvollmer
Copy link
Member Author

The "network" page itself has all the docs, including for the firewall. SO I guess the "network/firewall" page should show them as well.

image

mvollmer added a commit to mvollmer/cockpit that referenced this issue Sep 25, 2024
mvollmer added a commit to mvollmer/cockpit that referenced this issue Sep 25, 2024
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 1, 2024
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 3, 2024
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 3, 2024
@mvollmer mvollmer linked a pull request Oct 3, 2024 that will close this issue
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 3, 2024
For example, "network/firewall" has no manifest entry of its
own. Rather, it is a sub-page of "network" and should show the same
documentation.

We also need to check the parent first now, since for example
"metrics" is a sub-page of "system", but still wants to show its own
docs.

Fixes cockpit-project#21040
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 7, 2024
@jelly
Copy link
Member

jelly commented Oct 8, 2024

I think it makes sense to only show the firewall documentation on network/firewall and not on network. That makes me wonder, isn't the fix to fix the manifest to have a separate firewall entry like systemd/manifest.json?

mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 8, 2024
For example, "network/firewall" has no manifest entry of its
own. Rather, it is a sub-page of "network" and should show the same
documentation.

We also need to check the parent first now, since for example
"metrics" is a sub-page of "system", but still wants to show its own
docs.

Fixes cockpit-project#21040
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 15, 2024
For example, "network/firewall" has no manifest entry of its
own. Rather, it is a sub-page of "network" and should show the same
documentation.

We also need to check the parent first now, since for example
"metrics" is a sub-page of "system", but still wants to show its own
docs.

Fixes cockpit-project#21040
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 15, 2024
For example, "network/firewall" has no manifest entry of its
own. Rather, it is a sub-page of "network" and should show the same
documentation.

We also need to check the parent first now, since for example
"metrics" is a sub-page of "system", but still wants to show its own
docs.

Fixes cockpit-project#21040
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 15, 2024
For example, "network/firewall" has no manifest entry of its
own. Rather, it is a sub-page of "network" and should show the same
documentation.

We also need to check the parent first now, since for example
"metrics" is a sub-page of "system", but still wants to show its own
docs.

Fixes cockpit-project#21040
mvollmer added a commit to mvollmer/cockpit that referenced this issue Oct 23, 2024
For example, "network/firewall" has no manifest entry of its
own. Rather, it is a sub-page of "network" and should show the same
documentation.

We also need to check the parent first now, since for example
"metrics" is a sub-page of "system", but still wants to show its own
docs.

Fixes cockpit-project#21040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants