-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: Doesn't show "network" docs when on "network/firewall" page #21040
Comments
mvollmer
added a commit
to mvollmer/cockpit
that referenced
this issue
Oct 3, 2024
For example, "network/firewall" has no manifest entry of its own. Rather, it is a sub-page of "network" and should show the same documentation. We also need to check the parent first now, since for example "metrics" is a sub-page of "system", but still wants to show its own docs. Fixes cockpit-project#21040
I think it makes sense to only show the firewall documentation on network/firewall and not on network. That makes me wonder, isn't the fix to fix the manifest to have a separate firewall entry like systemd/manifest.json? |
mvollmer
added a commit
to mvollmer/cockpit
that referenced
this issue
Oct 8, 2024
For example, "network/firewall" has no manifest entry of its own. Rather, it is a sub-page of "network" and should show the same documentation. We also need to check the parent first now, since for example "metrics" is a sub-page of "system", but still wants to show its own docs. Fixes cockpit-project#21040
mvollmer
added a commit
to mvollmer/cockpit
that referenced
this issue
Oct 15, 2024
For example, "network/firewall" has no manifest entry of its own. Rather, it is a sub-page of "network" and should show the same documentation. We also need to check the parent first now, since for example "metrics" is a sub-page of "system", but still wants to show its own docs. Fixes cockpit-project#21040
mvollmer
added a commit
to mvollmer/cockpit
that referenced
this issue
Oct 15, 2024
For example, "network/firewall" has no manifest entry of its own. Rather, it is a sub-page of "network" and should show the same documentation. We also need to check the parent first now, since for example "metrics" is a sub-page of "system", but still wants to show its own docs. Fixes cockpit-project#21040
mvollmer
added a commit
to mvollmer/cockpit
that referenced
this issue
Oct 15, 2024
For example, "network/firewall" has no manifest entry of its own. Rather, it is a sub-page of "network" and should show the same documentation. We also need to check the parent first now, since for example "metrics" is a sub-page of "system", but still wants to show its own docs. Fixes cockpit-project#21040
mvollmer
added a commit
to mvollmer/cockpit
that referenced
this issue
Oct 23, 2024
For example, "network/firewall" has no manifest entry of its own. Rather, it is a sub-page of "network" and should show the same documentation. We also need to check the parent first now, since for example "metrics" is a sub-page of "system", but still wants to show its own docs. Fixes cockpit-project#21040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When on the "network/firewall" page, the "Help" menu does not include the networking docs:
The text was updated successfully, but these errors were encountered: