Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly tests did not succeed on fedora-38/updates-testing #1207

Closed
cockpituous opened this issue Sep 13, 2023 · 2 comments · Fixed by #1208
Closed

Nightly tests did not succeed on fedora-38/updates-testing #1207

cockpituous opened this issue Sep 13, 2023 · 2 comments · Fixed by #1208
Assignees
@martinpitt
Labels
nightly

Comments

@cockpituous
Copy link
Contributor

Tests failed on 29c1fc3
@martinpitt
Copy link
Member

Aha, that'd be a new ruff version in the tasks container:

# test/check-machines-settings:860:9: PT027 Use `pytest.raises` instead of unittest-style `assertRaises`

martinpitt added a commit to martinpitt/cockpit-machines that referenced this issue Sep 13, 2023
@martinpitt
ruff: Disable Pytest checks
e1a6f7f 
We don't use pytest in our test machinery right now, and every new ruff
version starts to complain about more things. The recent tasks container
update started to fail our tests with

> PT027 Use `pytest.raises` instead of unittest-style `assertRaises`

Disable the PT rules again.

Fixes cockpit-project#1207
@martinpitt martinpitt mentioned this issue Sep 13, 2023
Merged
@martinpitt
Copy link
Member

Fixed in #1208

@martinpitt martinpitt self-assigned this Sep 13, 2023
jelly pushed a commit that referenced this issue Sep 13, 2023
@martinpitt @jelly
ruff: Disable Pytest checks
fc76f9b 
We don't use pytest in our test machinery right now, and every new ruff
version starts to complain about more things. The recent tasks container
update started to fail our tests with

> PT027 Use `pytest.raises` instead of unittest-style `assertRaises`

Disable the PT rules again.

Fixes #1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinpitt martinpitt

Labels
nightly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ruff: Disable Pytest checks martinpitt/cockpit-machines
2 participants
@martinpitt @cockpituous