From 7dbcdc980c63e4a259af5d292507bf1a019ead6e Mon Sep 17 00:00:00 2001 From: Tomas Matus Date: Thu, 10 Aug 2023 10:38:12 +0200 Subject: [PATCH] fix checkbox label in delete storage modal --- src/components/common/machinesConnectionSelector.jsx | 2 +- src/components/storagePools/storagePoolDelete.jsx | 9 ++++----- src/machines.scss | 8 ++------ test/reference | 2 +- 4 files changed, 8 insertions(+), 13 deletions(-) diff --git a/src/components/common/machinesConnectionSelector.jsx b/src/components/common/machinesConnectionSelector.jsx index 9b2aaf18f..40f50f6b4 100644 --- a/src/components/common/machinesConnectionSelector.jsx +++ b/src/components/common/machinesConnectionSelector.jsx @@ -37,7 +37,7 @@ export const MachinesConnectionSelector = ({ onValueChanged, loggedUser, connect return ( 0 ? - { _("Also delete all volumes inside this pool:")} + label={_("Also delete all volumes inside this pool:")} + body={ - {volumes - .sort((a, b) => a.name.localeCompare(b.name)) + {volumes.sort((a, b) => a.name.localeCompare(b.name)) .map(vol => {vol.name}) } - } + } onChange={(_event, checked) => this.onValueChanged('deleteVolumes', checked)} /> : _("No volumes exist in this storage pool.")) : _("Deleting an inactive storage pool will only undefine the pool. Its content will not be deleted.") diff --git a/src/machines.scss b/src/machines.scss index 54153bfbc..94c6cc5ce 100644 --- a/src/machines.scss +++ b/src/machines.scss @@ -102,10 +102,6 @@ } } -// radio buttons rendered vertically in pf-m-horizontal https://github.com/patternfly/patternfly/issues/5787 -.pf-v5-c-form__group-control.pf-m-inline { - .pf-v5-c-radio { - width: auto; - display: grid; - } +#storage-pool-delete-volumes + label + span.pf-v5-c-check__body { + margin-top: 0; } diff --git a/test/reference b/test/reference index edc0dde91..2209b66c3 160000 --- a/test/reference +++ b/test/reference @@ -1 +1 @@ -Subproject commit edc0dde911bd9906c52aef377d9ce53dca521f96 +Subproject commit 2209b66c3f64456e4af13c9d95b85cea8d2bfd32