Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing name giturlparse #43

Open
jayvdb opened this issue Jul 14, 2019 · 3 comments
Open

Sharing name giturlparse #43

jayvdb opened this issue Jul 14, 2019 · 3 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 14, 2019

https://github.com/nephila/giturlparse/ is giturlparse on PyPI. It has become more active recently.

As the two modules share the installed module name giturlparse we should either aim to having the same API, or https://github.com/coala/git-url-parse should install itself into git_url_parse with a shim at giturlparse for backwards compatibility.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 14, 2019

aim to having the same API

This would be merely having the same top level function for the main utility, and a similar structure for the returned value, an a common exception for errors. How much similarity is open for discussion.

Another possibility is that we work towards backporting functionality and tests from here into https://github.com/nephila/giturlparse/ , if @yakky wants to commit to that goal. Then we share the name until the backport is complete. Or the inverse could happen if @nephila doesnt want to maintain their library forever.

@yakky
Copy link

yakky commented Jul 14, 2019

Hi @jayvdb
As wrote in the linked PR, I think it would pretty smart to converge the projects, it does not sound too smart to have two competing implementation for such use case.

I will have a look at this repo features, but given the goal it seems totally sensible and feasible to unite the efforts in a single application

@jayvdb
Copy link
Member Author

jayvdb commented Jul 19, 2019

Possibly also look for other similar libraries if there are any better than both of these projects.

https://github.com/pydanny/watdarepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants