-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aspectsYEAHBear #1573
Comments
The @coala/aspects-developers Opinions? |
yep it should, and we should probably implement Grammar( or Spelling)
aspect for the this
2017-04-01 16:40 GMT+01:00 Stefan Zimmermann <[email protected]>:
… The aspectsYEAHBear could also check if *aspectsYEAH* is always written
correctly :)
@coala/aspects-developers
<https://github.com/orgs/coala/teams/aspects-developers> Opinions?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#1573 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ9xolmMDWkXzjLOMwkZ4tp2V2wsOXmMks5rrm_YgaJpZM4Mwg_E>
.
|
annotating its(aspectsYEAHBear) results right away
2017-04-01 16:43 GMT+01:00 Christian Asnel Ngoulla <[email protected]>:
… yep it should, and we should probably implement Grammar( or Spelling)
aspect for the this
2017-04-01 16:40 GMT+01:00 Stefan Zimmermann ***@***.***>:
> The aspectsYEAHBear could also check if *aspectsYEAH* is always written
> correctly :)
>
> @coala/aspects-developers
> <https://github.com/orgs/coala/teams/aspects-developers> Opinions?
>
> —
> You are receiving this because you are on a team that was mentioned.
> Reply to this email directly, view it on GitHub
> <#1573 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJ9xolmMDWkXzjLOMwkZ4tp2V2wsOXmMks5rrm_YgaJpZM4Mwg_E>
> .
>
|
@AsnelChristian Something like |
@coala/aspects-developers So! Thanks to @Techievena we now have the coala/coala#4049 Time for the |
Add aspectYEAHBear to make sure `aspect` is always written with a lower case `a` and `aspectsYEAH` is always written with upper case `YEAH`. Closes coala#1573
Add aspectYEAHBear to make sure `aspect` is always written with a lower case `a` and `aspectsYEAH` is always written with upper case `YEAH`. Closes coala#1573
Add aspectsYEAHBear to make sure `aspect` is always written with a lower case `a` and `aspectsYEAH` is always written with upper case `YEAH`. Closes coala#1573
Creating a bear to do this, without being disabled by default in coala-quickstart, and removed from the docker, will cause errors in CI for other users repositories. This should be merged into coalaBear (which is already special-cased to avoid this problem) , and made into a more generic tool, where the default is not going to destroy other peoples repositories who dont adhere to this rule. |
"importance/high" - wtf. Please have some perspective. We have far more important problems. |
Add aspectsYEAHBear to make sure `aspect` is always written with a lower case `a` and `aspectsYEAH` is always written with upper case `YEAH`. Closes coala#1573
@jayvdb It should not be merged with the |
So now we will have a separate bear for each component of coala that wants to have its name written a certain way? |
@jayvdb I can't see anymore such components so far, especially components that get so much attention based on their naming... But we can and should of course share logic between those bears as much as possible to reduce overhead to a minimum :) |
And why not share logic between coalaBear and this new aspectsYEAHBear ? |
Based on @Techievena's great idea from coala/coala#4039 (comment) , we should grow the
aspectsYEAHBear
that checks if the terms aspect and aspects are always written lowercase according to coala/cEPs#69 , just like thecoalaBear
does it for the term coala: https://github.com/coala/coala-bears/blob/master/bears/general/coalaBear.pyThe
aspectsYEAHBear
of course needs an aspect for the above main task and is always open for any ideas about additional tasks to perform.@coala/aspects-developers
The text was updated successfully, but these errors were encountered: