Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspectsYEAHBear #1573

Open
userzimmermann opened this issue Apr 1, 2017 · 12 comments
Open

aspectsYEAHBear #1573

userzimmermann opened this issue Apr 1, 2017 · 12 comments

Comments

@userzimmermann
Copy link
Member

Based on @Techievena's great idea from coala/coala#4039 (comment) , we should grow the aspectsYEAHBear that checks if the terms aspect and aspects are always written lowercase according to coala/cEPs#69 , just like the coalaBear does it for the term coala: https://github.com/coala/coala-bears/blob/master/bears/general/coalaBear.py

The aspectsYEAHBear of course needs an aspect for the above main task and is always open for any ideas about additional tasks to perform.

@coala/aspects-developers

@userzimmermann
Copy link
Member Author

The aspectsYEAHBear could also check if aspectsYEAH is always written correctly :)

@coala/aspects-developers Opinions?

@AsnelChristian
Copy link
Member

AsnelChristian commented Apr 1, 2017 via email

@AsnelChristian
Copy link
Member

AsnelChristian commented Apr 1, 2017 via email

@userzimmermann
Copy link
Member Author

@AsnelChristian Something like Spelling.aspectsYEAH :)

@userzimmermann
Copy link
Member Author

@coala/aspects-developers So! Thanks to @Techievena we now have the aspectsYEAH aspect:

coala/coala#4049
https://github.com/coala/coala/blob/master/coalib/bearlib/aspects/Spelling.py#L12

Time for the aspectsYEAHBear! @pratyushprakash

pratyushprakash added a commit to pratyushprakash/coala-bears that referenced this issue Apr 11, 2017
Add aspectYEAHBear to make sure `aspect` is always
written with a lower case `a` and `aspectsYEAH` is
always written with upper case `YEAH`.

Closes coala#1573
pratyushprakash added a commit to pratyushprakash/coala-bears that referenced this issue Apr 11, 2017
Add aspectYEAHBear to make sure `aspect` is always
written with a lower case `a` and `aspectsYEAH` is
always written with upper case `YEAH`.

Closes coala#1573
pratyushprakash added a commit to pratyushprakash/coala-bears that referenced this issue Apr 11, 2017
Add aspectsYEAHBear to make sure `aspect` is always
written with a lower case `a` and `aspectsYEAH` is
always written with upper case `YEAH`.

Closes coala#1573
@jayvdb
Copy link
Member

jayvdb commented Apr 11, 2017

Creating a bear to do this, without being disabled by default in coala-quickstart, and removed from the docker, will cause errors in CI for other users repositories.

This should be merged into coalaBear (which is already special-cased to avoid this problem) , and made into a more generic tool, where the default is not going to destroy other peoples repositories who dont adhere to this rule.

@jayvdb
Copy link
Member

jayvdb commented Apr 11, 2017

"importance/high" - wtf. Please have some perspective. We have far more important problems.

pratyushprakash added a commit to pratyushprakash/coala-bears that referenced this issue Apr 11, 2017
Add aspectsYEAHBear to make sure `aspect` is always
written with a lower case `a` and `aspectsYEAH` is
always written with upper case `YEAH`.

Closes coala#1573
@userzimmermann
Copy link
Member Author

@jayvdb It should not be merged with the coalaBear but handled exactly the same way. I totally agree with you in that latter aspect :)

@jayvdb
Copy link
Member

jayvdb commented Apr 11, 2017

So now we will have a separate bear for each component of coala that wants to have its name written a certain way?

@userzimmermann
Copy link
Member Author

@jayvdb I can't see anymore such components so far, especially components that get so much attention based on their naming... But we can and should of course share logic between those bears as much as possible to reduce overhead to a minimum :)

@jayvdb
Copy link
Member

jayvdb commented Apr 11, 2017

And why not share logic between coalaBear and this new aspectsYEAHBear ?

@userzimmermann
Copy link
Member Author

@jayvdb This is what I also implicitly mean :) #1604 is not finished yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants