Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: Blank line error fix #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naveentata
Copy link

A new line is added at the end of bullets list

Fixes #4

generate Outdated
@@ -158,7 +158,7 @@ def recurse(aspect, level=0):
output += "* `" + subsub_name + " <" + subsub_name + "/README.rst>`_\n"
else:
output += "This aspect does not have any sub aspects.\n\n"

output += "\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I think this line should be inside the if (line 156). Because if the else branch you'd have three newlines but if the if branch executes, you'd have only one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please run the generate file to generate the latest version so that we can verify if it works perfectly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am not able to run the generate file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? If you're on linux, it's ./generate and if you're on Windows, you can do python generate. It's a Python file...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adtac Yeah,but it is showing some syntax error if I run ./generate.
screenshot from 2017-03-06 17-42-47

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using python3? Try python3 generate

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried python3 generate but, that too is showing some error
screenshot from 2017-03-09 22-00-37

A new line is added at the end of bullets list

Fixes coala#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants