-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate: Blank line error fix #6
base: master
Are you sure you want to change the base?
Conversation
generate
Outdated
@@ -158,7 +158,7 @@ def recurse(aspect, level=0): | |||
output += "* `" + subsub_name + " <" + subsub_name + "/README.rst>`_\n" | |||
else: | |||
output += "This aspect does not have any sub aspects.\n\n" | |||
|
|||
output += "\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I think this line should be inside the if
(line 156). Because if the else
branch you'd have three newlines but if the if
branch executes, you'd have only one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please run the generate
file to generate the latest version so that we can verify if it works perfectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am not able to run the generate file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? If you're on linux, it's ./generate
and if you're on Windows, you can do python generate
. It's a Python file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adtac Yeah,but it is showing some syntax error if I run ./generate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using python3? Try python3 generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new line is added at the end of bullets list Fixes coala#4
A new line is added at the end of bullets list
Fixes #4