Build image and push to GHCR #3634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for landscape ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for landscape ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
castrojo
requested changes
Dec 6, 2023
This builds an image by passing the Dockerfile to buildah and submits it to GHCR Note: Requires generating a key pair with cosign Signed-off-by: RJ Trujillo <[email protected]>
Signed-off-by: Jorge O. Castro <[email protected]>
|
Last commit needs to be signed, otherwise generally LGTM! |
Will handle that right now :) |
Signed-off-by: RJ Trujillo <[email protected]>
Signed-off-by: RJ Trujillo <[email protected]>
|
I think we'll need this for landscape2, RJ I'll follow up with you on this one separately. |
|
The landscape2 CLI tool is also distributed in a container image @castrojo. All the build and deployment workflows for all landscapes we host rely on it actually 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds an image by passing the Dockerfile to buildah and submits it to GHCR
Note: Requires generating a key pair with cosign
Pre-submission checklist:
Please check each of these after submitting your pull request:
repo_urlif your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.hosted_logosand referenced it there?