Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ghcr.io for this repo #3626

Closed
cafkafk opened this issue Dec 1, 2023 · 8 comments
Closed

use ghcr.io for this repo #3626

cafkafk opened this issue Dec 1, 2023 · 8 comments
Assignees
Labels
automation Changes that add automatic process improvement enhancement

Comments

@cafkafk
Copy link

cafkafk commented Dec 1, 2023

Since this project has a docker container, it would be valuable to distribute that container on the ghcr.io tied to this repo.

Here is an example from one of my projects https://github.com/cafkafk/rime/pkgs/container/rime.

This makes it a lot easier to use a project that includes a container.

@onlydole
Copy link
Member

onlydole commented Dec 1, 2023

@castrojo - this might be a great use case for your GitHub Actions 😄

@onlydole onlydole added enhancement automation Changes that add automatic process improvement labels Dec 1, 2023
@castrojo
Copy link
Member

castrojo commented Dec 1, 2023

Oooh!

Hey @cafkafk if you want first dibs on this and want to adjust and PR your example then I'd be happy to review. Always happy to help someone get their first cncf contribution in!

Or if not I can put it on my list for next week! Thanks for filing this, we probably want/need this stuff in lots of places across the org.

@cafkafk
Copy link
Author

cafkafk commented Dec 3, 2023

Always happy to help someone get their first cncf contribution in!

Thanks for the offer! Unfortunately I can already barely keep up with my github notifications, so I'll have to pass. Thanks for looking into this thou!

@EyeCantCU
Copy link

Hi all,

I've drafted a PR for this here: #3634

It needs a key pair generated by cosign to successfully work

@castrojo
Copy link
Member

castrojo commented Dec 6, 2023

I've generated a new cosign pair and PRed the new public key as #3636. I've set the private key as SIGNING_KEY in the repo settings as expected. Just needs another set of eyes to double check, thanks ya'll!

@EyeCantCU
Copy link

Sounds great! I believe it needs to be SIGNING_SECRET and not SIGNING_KEY (apologies for not covering that)

@castrojo
Copy link
Member

castrojo commented Dec 6, 2023

You're correct, I double checked and I got it right in the settings panel, but wrong in my comment. 😄 We should be good to go!

@tegioz
Copy link
Contributor

tegioz commented Jan 17, 2024

Hi!

We've just migrated the CNCF landscape to v2 and this issue probably no longer applies. Landscape2 provides a container image with the landscapes generator, in addition to some pre-built binaries for multiple platforms.

Please feel free to reopen if needed 🙂

@tegioz tegioz closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Changes that add automatic process improvement enhancement
Projects
None yet
Development

No branches or pull requests

5 participants