-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ghcr.io for this repo #3626
Comments
@castrojo - this might be a great use case for your GitHub Actions 😄 |
Oooh! Hey @cafkafk if you want first dibs on this and want to adjust and PR your example then I'd be happy to review. Always happy to help someone get their first cncf contribution in! Or if not I can put it on my list for next week! Thanks for filing this, we probably want/need this stuff in lots of places across the org. |
Thanks for the offer! Unfortunately I can already barely keep up with my github notifications, so I'll have to pass. Thanks for looking into this thou! |
Hi all, I've drafted a PR for this here: #3634 It needs a key pair generated by cosign to successfully work |
I've generated a new cosign pair and PRed the new public key as #3636. I've set the private key as SIGNING_KEY in the repo settings as expected. Just needs another set of eyes to double check, thanks ya'll! |
Sounds great! I believe it needs to be SIGNING_SECRET and not SIGNING_KEY (apologies for not covering that) |
You're correct, I double checked and I got it right in the settings panel, but wrong in my comment. 😄 We should be good to go! |
Hi! We've just migrated the CNCF landscape to v2 and this issue probably no longer applies. Landscape2 provides a container image with the landscapes generator, in addition to some pre-built binaries for multiple platforms. Please feel free to reopen if needed 🙂 |
Since this project has a docker container, it would be valuable to distribute that container on the ghcr.io tied to this repo.
Here is an example from one of my projects https://github.com/cafkafk/rime/pkgs/container/rime.
This makes it a lot easier to use a project that includes a container.
The text was updated successfully, but these errors were encountered: