-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delivery transaction doesn't confirm TPC-C standard #360
Comments
@eivanov89 Can you send a PR with your fix? |
@apavlo Sure, I will create the PR soon. |
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Sep 26, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Sep 26, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Sep 26, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Sep 26, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Oct 19, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Nov 26, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Nov 26, 2023
eivanov89
added a commit
to eivanov89/benchbase
that referenced
this issue
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi folks,
At @YDB we forked benchbase to implement TPC-C. Now we both share same bugs :)
Here you always iterate from 1 to terminalDistrictUpperID. It seems that original approach was to iterate from terminalDistrictLowerID (left unused) to terminalDistrictUpperID. It means that first terminal iterates districts from 1 to 2, next terminal - 1 to 3, ..., 1 to 10. But each terminal must iterate 1 to 10 according the standard (and I double checked TPC-C implementation in CockroachDB).
At YDB bugfix decreased tpmc by 4%. In my opinion, this bug is critical.
The text was updated successfully, but these errors were encountered: