Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] rocprofiler-register stub library #9493

Open
smuzaffar opened this issue Oct 31, 2024 · 7 comments
Open

[ROCm] rocprofiler-register stub library #9493

smuzaffar opened this issue Oct 31, 2024 · 7 comments

Comments

@smuzaffar
Copy link
Contributor

As discussed in here , this is proposal to create our own rocprofiler-register stub library to replace the one from rocm.

@fwyzard @makortel , if no objections then we can create such library during the rocm packging. One question should we rename the rocm's librocprofiler-register.so.0.3.0 to liborig-rocprofiler-register.so.0.3.0 and link our librocprofiler-register against it so that we only override rocprofiler_register_library_api_table symbol and rest (if there are any) can be loaded from the original lib?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Oct 31, 2024

assign core, heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: core,heterogeneous

@Dr15Jones,@fwyzard,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fwyzard
Copy link
Contributor

fwyzard commented Nov 1, 2024

No, the original library must not be included at all.
The original library links with the host libstdc++, which is the source of the problems discussed in cms-sw/cmssw#44821 .

@smuzaffar
Copy link
Contributor Author

ah ok @fwyzard
Should I just reope #9143 + changes for this stub lib or do you want to use latest ROCm 6.2

@fwyzard
Copy link
Contributor

fwyzard commented Nov 1, 2024

I would go with ROCm 6.2.2.

And the stub library needs more functions and a version bump in 6.2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants