-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] rocprofiler-register stub library #9493
Comments
cms-bot internal usage |
A new Issue was created by @smuzaffar. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign core, heterogeneous |
New categories assigned: core,heterogeneous @Dr15Jones,@fwyzard,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
No, the original library must not be included at all. |
I would go with ROCm 6.2.2. And the stub library needs more functions and a version bump in 6.2.x. |
As discussed in here , this is proposal to create our own rocprofiler-register stub library to replace the one from rocm.
@fwyzard @makortel , if no objections then we can create such library during the rocm packging. One question should we rename the rocm's
librocprofiler-register.so.0.3.0
toliborig-rocprofiler-register.so.0.3.0
and link ourlibrocprofiler-register
against it so that we only overriderocprofiler_register_library_api_table
symbol and rest (if there are any) can be loaded from the original lib?The text was updated successfully, but these errors were encountered: