Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout parameters passed to Elasticsearch object #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kusha
Copy link
Contributor

@kusha kusha commented Sep 4, 2018

Create timeout and retry on timeout parameters in the handler constuructor.
Parameters passed to Elasticsearch object, and used while performing bulk_send().

Create timeout and retry on timeout parameters in the handler constuructor.
Parameters passed to Elasticsearch object, and used while performing bulk_send().
@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #54 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage      83%   83.43%   +0.43%     
==========================================
  Files           2        2              
  Lines         153      157       +4     
  Branches       20       20              
==========================================
+ Hits          127      131       +4     
  Misses         22       22              
  Partials        4        4
Impacted Files Coverage Δ
cmreslogging/handlers.py 82.66% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e042bb...1c92ac9. Read the comment docs.

@KonstantinSchubert
Copy link
Collaborator

@cmanaha I think this is a very useful feature and I would like to have this too. Can I do anything to support merging this?

@KonstantinSchubert
Copy link
Collaborator

@cmanaha Ping

@cmanaha
Copy link
Owner

cmanaha commented Apr 18, 2019

@KonstantinSchubert ; Apologies for about being completely absent. Konstantin, I've added you to the collaborators of the project. I have not managed to allocate and commit time for keeping this project up to date for the last few months, and the project indeed still need some love (this pull request is an example, + eventually upgrade to 6, and others).

I have to disclose also I joined AWS about 4 months ago. I'd like at some point to spend time to get some of the other integrations people have been asking (role, auth certificates, and stuff like that), but I'll not be able to commit the time for the next 3 months.

Copy link
Collaborator

@KonstantinSchubert KonstantinSchubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot for the contribution.
It's very useful, I was looking for this feature recently! 👍

I have made some adjustments to the doc strings to bring them more in line with the existing ones.

If you agree then you can apply the suggested changes.

cmreslogging/handlers.py Outdated Show resolved Hide resolved
cmreslogging/handlers.py Outdated Show resolved Hide resolved
@KonstantinSchubert
Copy link
Collaborator

@kusha Paging.

@kusha
Copy link
Contributor Author

kusha commented Apr 24, 2019

@KonstantinSchubert I've applied your suggestions. Feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants