Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for latest tonic #112

Open
clux opened this issue Oct 28, 2022 · 3 comments
Open

Add test for latest tonic #112

clux opened this issue Oct 28, 2022 · 3 comments

Comments

@clux
Copy link
Owner

clux commented Oct 28, 2022

Given sudden protobuf inclusion from there, and it being such a popular dependency, we should have a test here for it to catch changes more easily.

#105 (comment) suggests we might need protobuf-dev now.

@Zizico2
Copy link

Zizico2 commented Oct 31, 2022

#105 (comment) author here.

tonic works fine. The problem is tonic-types.

@clux
Copy link
Owner Author

clux commented Nov 1, 2022

Either way, would like to be made aware of things breaking at the CI level before everyone else notices the image does't work :-)

I have added libprotobuf-dev speculatively as it's what tonic requires, please lemme know if it doesn't work (after the next build)!

Leaving the issue open because I still want to have a test crate here here that uses tonic in a basic way (like we do for other popular crates).

@Zizico2
Copy link

Zizico2 commented Nov 2, 2022

Yep, it's building now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants