Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal metrics support. #249

Open
fly3366 opened this issue Oct 27, 2023 · 2 comments
Open

Internal metrics support. #249

fly3366 opened this issue Oct 27, 2023 · 2 comments

Comments

@fly3366
Copy link

fly3366 commented Oct 27, 2023

Feature Request

Crates

volo-otel? volo-var?

Motivation

like bvar in brpc. support export to otel or openmetrics format to prometheus easy.

export runtime metrics, like eventloop delay.

Proposal

like bvar. write metrics var to thread local storage. and merge all tls on read.

Alternatives

if not impl it in framework. user may need do it on application layer and hard to monitor runtime metrics. may conflict with volo's better perf. such like some prom client use one instance and need mutex. it may conflict with volo's slogan lock free.

@PureWhiteWu
Copy link
Member

export runtime metrics, like eventloop delay

Hi, seems you are asking for some metrics of tokio? https://tokio.rs/blog/2022-02-announcing-tokio-metrics

We also have some apis for tracing, such as stat_tracer/span_provider of server, and you can also use a layer to get the stats of client from client context.

There's CommonStats in the context and also server and client specified stats in their own context.

Is this what you want?

@PureWhiteWu
Copy link
Member

Hi, do you have any further question or something that need to be improved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants