fix: raw_struct will generate bad code when thrift has typedef #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
为
raw_structextension 增加一个新的 templateTypedef用于覆盖默认 template 中的Typedef其删除了默认
Typedef中生成NewStruct的逻辑Motivation and Context
问题：
如果 Thrift 中定义了
typedef A=B，在代码生成的过程中，默认 template 中的Typedef会为A生成NewStruct相关的 func，其会调用B的NewStruct。但是如果使用了
raw_structextension，thriftgo 并不会为B生成NewStruct，导致编译失败。Related Issue