Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: only write StructEnd while WriteEmpty() #28

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Jul 10, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • opt: only write StructEnd while WriteEmpty()
  • opt: support incorrect quoted go.tag annotation input
    zh(optional):

(Optional) Which issue(s) this PR fixes:

when defaulted/required field is a self-referenced struct type, WriteEmpty() may introduce dead loop since it recursively write empty value for every fields of the struct

(optional) The PR that updates user documentation:

@AsterDY AsterDY merged commit 7965a6a into main Jul 10, 2023
7 checks passed
@AsterDY AsterDY deleted the opt/write_empty branch June 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant