Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make file input public #2982

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

katiegeorge
Copy link
Member

Description

This pulls file input out of internal and into the public folder.

This PR is part one of multiple for file upload decomposition, to make the pull requests easier to review.

Full plan:

  • File dropzone (internal)
  • File input (internal)
  • File token group (internal)
  • File dropzone (external)
  • File input (external) - this PR
  • File token group (external)
  • Adding file-upload variant to button group

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (7175cd1) to head (21322b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2982   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         769      770    +1     
  Lines       21766    21771    +5     
  Branches     7384     7441   +57     
=======================================
+ Hits        20955    20960    +5     
- Misses        758      803   +45     
+ Partials       53        8   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge katiegeorge changed the title feat: Make file input external feat: Make file input public Nov 5, 2024
@katiegeorge katiegeorge marked this pull request as ready for review November 5, 2024 00:35
@katiegeorge katiegeorge requested a review from a team as a code owner November 5, 2024 00:35
@katiegeorge katiegeorge removed the request for review from a team November 5, 2024 00:35
"type": "string",
},
{
"deprecatedTag": "Custom CSS is not supported. For testing and other use cases, use [data attributes](https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes).",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid having deprecated className and id in new components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants