Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve hidden breadcrumbs detection #2968

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

just-boris
Copy link
Member

Description

:empty selector does not match when there is an empty DOM element: <AppLayout breadcrumbs={<div />}>. Fix this by replacing CSS selector with Javascript

Related links, issue #, if available: n/a

How has this been tested?

Deployed to my dev pipeline to reproduce the original issue. Fixed now

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (ba58915) to head (6d94548).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2968   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         768      769    +1     
  Lines       21750    21753    +3     
  Branches     7434     7444   +10     
=======================================
+ Hits        20935    20938    +3     
+ Misses        807      762   -45     
- Partials        8       53   +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant