Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FileInput component (internal) #2964

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

katiegeorge
Copy link
Member

@katiegeorge katiegeorge commented Oct 31, 2024

Reverts #2959

Also, this adds an additional hidden class to allow it to be picked up by the clickable elements integration test. The class removes the deprecated clip property and replaces it with a reusable hidden util.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (02a8ba3) to head (23b5a3f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
+ Coverage   96.25%   96.27%   +0.02%     
==========================================
  Files         769      770       +1     
  Lines       21736    21752      +16     
  Branches     7430     7380      -50     
==========================================
+ Hits        20921    20941      +20     
+ Misses        807      758      -49     
- Partials        8       53      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge katiegeorge marked this pull request as ready for review October 31, 2024 21:11
@katiegeorge katiegeorge requested a review from a team as a code owner October 31, 2024 21:11
@katiegeorge katiegeorge requested review from taheramr, connorlanigan and pan-kot and removed request for a team and taheramr October 31, 2024 21:11
@katiegeorge katiegeorge added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 20fb841 Nov 4, 2024
39 checks passed
@katiegeorge katiegeorge deleted the revert-2959-revert-file-input branch November 4, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants