Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix code reuse between app layout and alert/flashbar runtime API #2963

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

just-boris
Copy link
Member

Description

Make sure that when we refactor something for app layout, we do not break flashbar

Related links, issue #, if available: n/a

How has this been tested?

Locally (visited app layout and flashbar dev pages) + all tests in dry-run

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines -19 to -20
const activeDrawersIds = useContext(ActiveDrawersContext);
const isVisible = !!id && activeDrawersIds.includes(id);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the problematic code. It was unintentionally included into the flashbar runtime API too, which is unexpected

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (02a8ba3) to head (a0c9a56).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2963   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         769      768    -1     
  Lines       21736    21742    +6     
  Branches     7430     7430           
=======================================
+ Hits        20921    20927    +6     
  Misses        807      807           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review October 31, 2024 15:41
@just-boris just-boris requested a review from a team as a code owner October 31, 2024 15:41
@just-boris just-boris requested review from connorlanigan and removed request for a team October 31, 2024 15:41
@just-boris just-boris added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 1d06808 Nov 1, 2024
37 checks passed
@just-boris just-boris deleted the split-runtime-wrappers branch November 1, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants