Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test analytics metadata in a table with empty header #2948

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Al-Dani
Copy link
Member

@Al-Dani Al-Dani commented Oct 29, 2024

Description

Add a test to cover use case from this PR.

Related links, issue #, if available: AWSUI-59898

How has this been tested?

locally

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (8f5431a) to head (5e7a60a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2948    +/-   ##
========================================
  Coverage   96.27%   96.27%            
========================================
  Files         770      770            
  Lines       21752    21752            
  Branches     7380     7036   -344     
========================================
  Hits        20941    20941            
- Misses        758      803    +45     
+ Partials       53        8    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Al-Dani Al-Dani marked this pull request as ready for review October 31, 2024 08:18
@Al-Dani Al-Dani requested a review from a team as a code owner October 31, 2024 08:18
@Al-Dani Al-Dani requested review from YueyingLu and removed request for a team October 31, 2024 08:18
@Al-Dani Al-Dani added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit b7ad907 Oct 31, 2024
37 checks passed
@Al-Dani Al-Dani deleted the table-empty-analytics-test branch October 31, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants