Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates drawers tests #1588

Merged
merged 3 commits into from
Oct 2, 2023
Merged

chore: Updates drawers tests #1588

merged 3 commits into from
Oct 2, 2023

Conversation

katiegeorge
Copy link
Member

Description

As part of moving drawers from beta to public, we made the decision to change the name of findDrawersSlider to findActiveDrawerResizeHandle. We also decided findDrawersDesktopTriggersContainer and findDrawersMobileTriggersContainer were unnecessary and added bloat, so I removed the instances of those and refactored the tests that used them.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2a586a4) 94.05% compared to head (3ddaf51) 94.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   94.05%   94.04%   -0.02%     
==========================================
  Files         649      649              
  Lines       17584    17579       -5     
  Branches     5781     5780       -1     
==========================================
- Hits        16539    16532       -7     
- Misses        976      978       +2     
  Partials       69       69              
Files Coverage Δ
src/app-layout/drawer/index.tsx 98.57% <100.00%> (-0.03%) ⬇️
src/app-layout/mobile-toolbar/index.tsx 94.28% <100.00%> (ø)
src/app-layout/visual-refresh/drawers.tsx 91.76% <ø> (ø)
src/test-utils/dom/app-layout/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Al-Dani
Al-Dani previously approved these changes Oct 2, 2023
@just-boris
Copy link
Member

Rebased because #1597 added more tests that now need rename

@katiegeorge katiegeorge merged commit 576080f into main Oct 2, 2023
31 checks passed
@katiegeorge katiegeorge deleted the kg/update-drawers-tests branch October 2, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants