fix: Don't pass through form field context to inputs in date range picker dropdown #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 94.04% 94.05%
=======================================
Files 649 649
Lines 17565 17568 +3
Branches 5767 5772 +5
=======================================
+ Hits 16519 16523 +4
+ Misses 977 976 -1
Partials 69 69
☔ View full report in Codecov by Sentry. |
avinashbot
force-pushed
the
date-range-picker-formfield
branch
from
c58cec9
to
90cbf7b
Compare
avinashbot
force-pushed
the
date-range-picker-formfield
branch
from
90cbf7b
to
f01314e
Compare
pan-kot
reviewed
Oct 2, 2023
pan-kot
previously approved these changes
Oct 2, 2023
avinashbot
force-pushed
the
date-range-picker-formfield
branch
from
f01314e
to
30ebbd7
Compare
pan-kot
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The form field wrapper should only auto-label the trigger, and not indiscriminately extend out to every input inside the dropdown. This cancels out the form field context around the dropdown.
Related links, issue #, if available: AWSUI-22471
How has this been tested?
Added tests.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.