Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Re-add margin for VR sticky-scrollbar when offset #1582

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Sep 26, 2023

Description

Re-added the margin that was necessary for avoiding sticky scrollbar overlap with interactive elements on a VR compact mode table.
This regression was introduced here: https://github.com/cloudscape-design/components/pull/1554/files#diff-b75a1d7e7c07f45b0c5b02301c632dc0cd30bc15c824eb2d951d1f697cd22803L41-L43 and caught on visual regression tests.

How has this been tested?

dev-v3-rucarva pipeline screenshot tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6544a4d) 94.01% compared to head (a6ff934) 94.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1582   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files         649      649           
  Lines       17533    17533           
  Branches     5760     5760           
=======================================
  Hits        16484    16484           
  Misses        980      980           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubencarvalho rubencarvalho removed the request for review from a team September 26, 2023 09:03
@rubencarvalho rubencarvalho merged commit 26cee13 into main Sep 26, 2023
30 of 32 checks passed
@rubencarvalho rubencarvalho deleted the chore/sticky-scrollbar-vr-margin branch September 26, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants