Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix test page and flaky test #1573

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

jperals
Copy link
Member

@jperals jperals commented Sep 22, 2023

Description

A leftover useEffect was interfering with tests, causing flakiness.

Also, correctly set loading back to asyncLoading instead of false when closing the dropdown, so that it the page state is correctly reset to its initial state also when asyncLoading is true.

How has this been tested?

  • Ran the integration tests 3 times, all successfully
  • Manually tested the page to make sure it keeps behaving as expected.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (c3fe8ad) 93.99% compared to head (3c2b45e) 93.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
- Coverage   93.99%   93.98%   -0.02%     
==========================================
  Files         649      649              
  Lines       17497    17497              
  Branches     5734     5734              
==========================================
- Hits        16447    16445       -2     
- Misses        981      983       +2     
  Partials       69       69              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals jperals changed the title chore: Fine tune test page, fix flaky test chore: Fine test page and flaky test Sep 22, 2023
@jperals jperals changed the title chore: Fine test page and flaky test chore: Fix test page and flaky test Sep 22, 2023
@jperals jperals marked this pull request as ready for review September 22, 2023 09:28
@jperals jperals requested a review from a team as a code owner September 22, 2023 09:28
@jperals jperals requested review from pan-kot and removed request for a team September 22, 2023 09:28
@jperals jperals merged commit 0c7d031 into main Sep 22, 2023
33 checks passed
@jperals jperals deleted the fix/dropdown-width-flaky-test branch September 22, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants