feat: Mimics tools behavior when there is only one drawer #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiegeorge
force-pushed
the
kg/single-drawer-behavior
branch
from
fa222b7
to
1076cbb
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
- Coverage 94.01% 94.00% -0.01%
==========================================
Files 649 649
Lines 17524 17533 +9
Branches 5753 5760 +7
==========================================
+ Hits 16475 16482 +7
- Misses 980 982 +2
Partials 69 69
☔ View full report in Codecov by Sentry. |
katiegeorge
force-pushed
the
kg/single-drawer-behavior
branch
2 times, most recently
from
63ac2a2
to
2ea7f1b
Compare
Al-Dani
approved these changes
Sep 25, 2023
katiegeorge
force-pushed
the
kg/single-drawer-behavior
branch
from
2ea7f1b
to
9601326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A single drawer acted slightly different than tools - the entire bar was not clickable (only the icon), and it would keep the trigger bar visible when opened. This PR adjusts those two features so that a single drawer now acts the same as tools.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.