Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix funnel support for modals #1494

Merged
merged 1 commit into from
Sep 14, 2023
Merged

chore: Fix funnel support for modals #1494

merged 1 commit into from
Sep 14, 2023

Conversation

connorlanigan
Copy link
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (7e6282c) 93.98% compared to head (135599c) 93.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   93.98%   93.99%   +0.01%     
==========================================
  Files         644      644              
  Lines       17366    17381      +15     
  Branches     5700     5702       +2     
==========================================
+ Hits        16321    16338      +17     
+ Misses        976      974       -2     
  Partials       69       69              
Files Changed Coverage Δ
src/cards/index.tsx 93.97% <ø> (ø)
src/container/index.tsx 100.00% <ø> (ø)
src/container/internal.tsx 100.00% <100.00%> (ø)
...xpandable-section/expandable-section-container.tsx 100.00% <100.00%> (ø)
src/expandable-section/index.tsx 100.00% <100.00%> (ø)
src/expandable-section/internal.tsx 93.33% <100.00%> (ø)
...internal/analytics/components/analytics-funnel.tsx 99.35% <100.00%> (+0.01%) ⬆️
src/internal/analytics/hooks/use-funnel.ts 100.00% <100.00%> (ø)
src/modal/internal.tsx 100.00% <100.00%> (ø)
src/table/index.tsx 100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorlanigan connorlanigan merged commit 6d19d70 into main Sep 14, 2023
29 checks passed
@connorlanigan connorlanigan deleted the funnels/modals branch September 14, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants