-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor and fix AppLayout and side navigation panel state and behaviour #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rigger button click
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 93.80% 93.82% +0.01%
==========================================
Files 639 640 +1
Lines 17245 17244 -1
Branches 5675 5671 -4
==========================================
+ Hits 16177 16179 +2
+ Misses 995 992 -3
Partials 73 73
☔ View full report in Codecov by Sentry. |
rubencarvalho
changed the title
Rucarva applayout navigation panel
fix: Refactor and fix AppLayout and side navigation panel state and behaviour
Aug 28, 2023
rubencarvalho
requested review from
connorlanigan,
avinashbot and
timogasda
and removed request for
a team
August 28, 2023 11:06
timogasda
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-adding #1434. It was reverted (#1485) to unblock our pipelines. We had a problem in our integration tests setup. Now, the fix for the tests has been deployed (CR-99922192), meaning this PR can finally be merged!
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.