Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor and fix AppLayout and side navigation panel state and behaviour #1490

Merged
merged 19 commits into from
Aug 28, 2023

Conversation

rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Aug 28, 2023

Description

Re-adding #1434. It was reverted (#1485) to unblock our pipelines. We had a problem in our integration tests setup. Now, the fix for the tests has been deployed (CR-99922192), meaning this PR can finally be merged!

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (334a015) 93.80% compared to head (cb4b7d4) 93.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   93.80%   93.82%   +0.01%     
==========================================
  Files         639      640       +1     
  Lines       17245    17244       -1     
  Branches     5675     5671       -4     
==========================================
+ Hits        16177    16179       +2     
+ Misses        995      992       -3     
  Partials       73       73              
Files Changed Coverage Δ
...c/expandable-section/expandable-section-header.tsx 100.00% <ø> (ø)
src/side-navigation/internal.tsx 100.00% <ø> (ø)
src/app-layout/index.tsx 92.83% <100.00%> (+0.05%) ⬆️
src/app-layout/visual-refresh/context.tsx 89.51% <100.00%> (+0.14%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubencarvalho rubencarvalho changed the title Rucarva applayout navigation panel fix: Refactor and fix AppLayout and side navigation panel state and behaviour Aug 28, 2023
@rubencarvalho rubencarvalho marked this pull request as ready for review August 28, 2023 11:06
@rubencarvalho rubencarvalho requested a review from a team as a code owner August 28, 2023 11:06
@rubencarvalho rubencarvalho requested review from connorlanigan, avinashbot and timogasda and removed request for a team August 28, 2023 11:06
@rubencarvalho rubencarvalho merged commit 9cd41aa into main Aug 28, 2023
25 checks passed
@rubencarvalho rubencarvalho deleted the rucarva-applayout-navigation-panel branch August 28, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants