Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark Table component as a funnel substep #1483

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

connorlanigan
Copy link
Member

Description

After this change, the Table component is treated as a substep when it comes to funnel metrics, i.e. it is treated like a container. This does not apply to the embedded variants of the Table, because those are expected to already have a container around them.

See also the equivalent change for Cards: #1362

Related links, issue #, if available: n/a

How has this been tested?

Extended the unit test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@connorlanigan connorlanigan requested a review from a team as a code owner August 25, 2023 11:36
@connorlanigan connorlanigan requested review from avinashbot and removed request for a team August 25, 2023 11:36
Copy link
Member

@avinashbot avinashbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching variants will cause React to rerender from scratch, but... I don't see anyone switching variants around dynamically...

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f0d128b) 93.79% compared to head (369fbfa) 93.79%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         639      639           
  Lines       17234    17237    +3     
  Branches     5667     5668    +1     
=======================================
+ Hits        16165    16168    +3     
  Misses        996      996           
  Partials       73       73           
Files Changed Coverage Δ
src/table/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorlanigan connorlanigan merged commit ebe2f92 into main Aug 25, 2023
24 checks passed
@connorlanigan connorlanigan deleted the funnels/table-as-substep branch August 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants