Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Table grid nav updates #1478

Merged
merged 4 commits into from
Aug 28, 2023
Merged

chore: Table grid nav updates #1478

merged 4 commits into from
Aug 28, 2023

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Aug 23, 2023

Description

Made changes to the table grid navigation based on an integration attempt (see #1480).

The main changes are:

  • Moving from focused cell to a cell containing one focusable element focuses the element and not the cell itself.
  • When focus is inside a widget cell the Tab/Shift+Tab can be used to move focus back to the table.
  • The navigation now works when the first data row index is other than 1.

How has this been tested?

  • New unit tests
  • Updated existing integ test
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner August 23, 2023 21:12
@pan-kot pan-kot requested review from rubencarvalho, avinashbot, gethinwebster and a team and removed request for a team August 23, 2023 21:12
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.02% ⚠️

Comparison is base (99e8bbf) 93.78% compared to head (0f6ea43) 93.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.02%     
==========================================
  Files         639      639              
  Lines       17228    17257      +29     
  Branches     5665     5677      +12     
==========================================
+ Hits        16158    16183      +25     
- Misses        997     1001       +4     
  Partials       73       73              
Files Changed Coverage Δ
src/table/table-role/table-role-helper.ts 96.07% <83.33%> (-3.93%) ⬇️
src/table/table-role/utils.ts 98.14% <97.77%> (-1.86%) ⬇️
src/table/internal.tsx 99.25% <100.00%> (ø)
src/table/table-role/use-grid-navigation.ts 99.23% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris removed the request for review from a team August 24, 2023 14:36
@pan-kot pan-kot merged commit fb4b027 into main Aug 28, 2023
26 checks passed
@pan-kot pan-kot deleted the table-grid-nav-updates branch August 28, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants