fix: Ensure inline-icon dropdown has active states #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gethinwebster
commented
Aug 10, 2023
| @@ -141,9 +150,7 @@ export default function () { | |||
| permutations={permutations} | |||
| render={permutation => ( | |||
| <Box margin={{ bottom: 'xxl' }} className={styles['dropdown-permutation']}> | |||
| <Dropdown trigger={null} open={true}> | |||
There was a problem hiding this comment.
the usage of Dropdown here was part of the cause of recent flakiness in these screenshot tests, and doesn't seem necessary if we're just interested in testing the actual items
avinashbot
approved these changes
Aug 10, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 631 631
Lines 16893 16893
Branches 5581 5581
=======================================
Hits 15806 15806
Misses 1014 1014
Partials 73 73 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure inline-icon dropdown has active states
Related links, issue #, if available: AWSUI-21904
How has this been tested?
Updated visual regression tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.