Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add text-status-warning color to Box #1432

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

gethinwebster
Copy link
Member

Description

Add the new warning color to the Box component, to match with Alert, StatusIndicator etc.

Related links, issue #, if available: AWSUI-21899

How has this been tested?

Added new tests/permutations

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster gethinwebster requested a review from a team as a code owner August 10, 2023 08:41
@gethinwebster gethinwebster requested review from abdhalees and removed request for a team August 10, 2023 08:41
abdhalees
abdhalees previously approved these changes Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e223ba2) 93.56% compared to head (b6c6b25) 93.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1432   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         631      631           
  Lines       16893    16893           
  Branches     5581     5581           
=======================================
  Hits        15806    15806           
  Misses       1014     1014           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster merged commit 2932ce0 into main Aug 10, 2023
24 checks passed
@gethinwebster gethinwebster deleted the box-color-warning branch August 10, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants