Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use i18nStrings as fallback flash icon labels #1426

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

gethinwebster
Copy link
Member

Description

Fall back to component-level i18nStrings if individual flash item labels aren't provided

Related links, issue #, if available: n/a

How has this been tested?

New unit tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc92170) 93.56% compared to head (87ec2f1) 93.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1426   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         631      631           
  Lines       16880    16888    +8     
  Branches     5570     5577    +7     
=======================================
+ Hits        15793    15801    +8     
  Misses       1014     1014           
  Partials       73       73           
Files Changed Coverage Δ
src/flashbar/collapsible-flashbar.tsx 98.02% <ø> (ø)
src/flashbar/flash.tsx 100.00% <100.00%> (ø)
src/flashbar/non-collapsible-flashbar.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster merged commit 45f7d2f into main Aug 9, 2023
24 checks passed
@gethinwebster gethinwebster deleted the flash-labels branch August 9, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants