Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funnel complete event #1421

Closed
wants to merge 1 commit into from
Closed

Add funnel complete event #1421

wants to merge 1 commit into from

Conversation

YueyingLu
Copy link
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc92170) 93.56% compared to head (0af0eee) 93.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         631      631           
  Lines       16880    16884    +4     
  Branches     5570     5570           
=======================================
+ Hits        15793    15797    +4     
  Misses       1014     1014           
  Partials       73       73           
Files Changed Coverage Δ
...internal/analytics/components/analytics-funnel.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YueyingLu YueyingLu closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant