chore: Upgrade tsconfigs #1419
Merged
chore: Upgrade tsconfigs #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
force-pushed
the
update-tsconfig
branch
2 times, most recently
from
dc2d596
to
c4093fc
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 631 631
Lines 16880 16880
Branches 5570 5570
=======================================
Hits 15793 15793
Misses 1014 1014
Partials 73 73 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
update-tsconfig
branch
from
c4093fc
to
0d9d9c2
Compare
just-boris
force-pushed
the
update-tsconfig
branch
from
0d9d9c2
to
16bdb5c
Compare
just-boris
commented
Aug 7, 2023
| async assertOptionSelected(groupNumber: number, optionNumber: number, isSelected: boolean) { | ||
| const className = await this.getElementAttribute(this.getOptionInGroup(groupNumber, optionNumber), 'class'); | ||
| assert.equal( | ||
| className.indexOf(selectableItemStyles.selected), |
There was a problem hiding this comment.
This line contained a bug, used indexOf() instead of indexOf() > -1.
Because this code is not used in any tests, it is easier to remove than fixing
YueyingLu
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring them up to date with our supported browsers
Related links, issue #, if available: n/a
How has this been tested?
Updated a few
indexOftoincludesto show that modern functions are supportedReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.