Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Parallel release action for components package #1414

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

timogasda
Copy link
Member

@timogasda timogasda commented Aug 4, 2023

Description

This adds a special release task for the components repository that executes the three test types (unit, integ, a11y) in parallel. Execution time is almost halved, from ~60min to ~35min.

Tested in my dev branch: https://github.com/cloudscape-design/components/actions/runs/5781899944.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a43902) 93.56% compared to head (eb418d0) 93.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files         630      630           
  Lines       16879    16879           
  Branches     5570     5570           
=======================================
  Hits        15792    15792           
  Misses       1014     1014           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timogasda timogasda marked this pull request as ready for review August 7, 2023 07:24
@timogasda timogasda requested a review from a team as a code owner August 7, 2023 07:24
@timogasda timogasda requested review from avinashbot and removed request for a team August 7, 2023 07:24
with:
node-version: 16
- run: npm install --force
- run: npm run build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could save another ~5min in total if we built only once and then move around the assets, but it didn't really feel worth the effort.

@timogasda timogasda merged commit 5fb7188 into main Aug 7, 2023
29 checks passed
@timogasda timogasda deleted the gasda/parallel-release branch August 7, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants