Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Center side navigation header text vertically when icon is present #1412

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

jperals
Copy link
Member

@jperals jperals commented Aug 4, 2023

Description

Because icon and header text in Side navigation are both anchored to the top, if the icon is taller the header looks like this:

Screenshot 2023-08-04 at 13 23 06

After this PR, it looks like this:
Screenshot 2023-08-04 at 13 22 21

When the icon is not taller than the header text, there should be no visual changes.

Ticket: AWSUI-20266

How has this been tested?

  • Added new permutations
  • Verified Backstop failures, they are expected because of the new permutations. Our pipeline visual regression tests should not fail because they compare each permutation individually.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe5918e) 93.97% compared to head (cd5b416) 93.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files         642      642           
  Lines       17313    17313           
  Branches     5691     5691           
=======================================
  Hits        16270    16270           
  Misses        973      973           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals jperals changed the title fix: Center side navigation title vertically when icon is present fix: Center side navigation header text vertically when icon is present Aug 4, 2023
@jperals jperals marked this pull request as ready for review August 29, 2023 12:40
@jperals jperals requested a review from a team as a code owner August 29, 2023 12:40
@jperals jperals requested review from avinashbot and removed request for a team August 29, 2023 12:40
@jperals jperals merged commit 5595225 into main Sep 6, 2023
23 of 24 checks passed
@jperals jperals deleted the fix/side-navigation-title-vertical-alignment branch September 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants