Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use utils from toolkit #1406

Merged
merged 5 commits into from
Aug 15, 2023
Merged

refactor: Use utils from toolkit #1406

merged 5 commits into from
Aug 15, 2023

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Aug 3, 2023

Description

Use more utilities from component-toolkit

How has this been tested?

Existing tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot changed the title Use utils from toolkit refactor: Use utils from toolkit Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (9134265) 93.55% compared to head (2dc7f21) 93.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
- Coverage   93.55%   93.52%   -0.04%     
==========================================
  Files         630      626       -4     
  Lines       16875    16818      -57     
  Branches     5570     5562       -8     
==========================================
- Hits        15788    15729      -59     
- Misses       1014     1016       +2     
  Partials       73       73              
Files Changed Coverage Δ
src/app-layout/utils/use-content-width.ts 92.85% <ø> (ø)
src/app-layout/utils/use-observed-element.ts 100.00% <ø> (ø)
src/internal/hooks/use-dynamic-overlap/index.ts 100.00% <ø> (ø)
src/internal/hooks/use-mouse-down-target.ts 100.00% <ø> (ø)
src/pie-chart/labels.tsx 97.77% <ø> (ø)
src/popover/container.tsx 46.66% <ø> (ø)
...ource-selector/s3-in-context/use-versions-fetch.ts 100.00% <ø> (ø)
src/split-panel/bottom.tsx 100.00% <ø> (ø)
src/table/use-sticky-header.ts 82.35% <ø> (ø)
src/app-layout/index.tsx 93.49% <100.00%> (ø)
... and 13 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot marked this pull request as ready for review August 3, 2023 15:04
@pan-kot pan-kot requested a review from a team as a code owner August 3, 2023 15:04
@pan-kot pan-kot requested review from connorlanigan and removed request for a team August 3, 2023 15:04
@pan-kot pan-kot merged commit 2ca759e into main Aug 15, 2023
24 checks passed
@pan-kot pan-kot deleted the use-utils-from-toolkit branch August 15, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants